Fix read and write racing on multiple processes.#1941
Merged
gaborbernat merged 1 commit intopypa:masterfrom Sep 18, 2020
frostming:atomic-write
Merged
Fix read and write racing on multiple processes.#1941gaborbernat merged 1 commit intopypa:masterfrom frostming:atomic-write
gaborbernat merged 1 commit intopypa:masterfrom
frostming:atomic-write
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1941 +/- ##
==========================================
- Coverage 93.98% 93.89% -0.10%
==========================================
Files 86 86
Lines 4225 4228 +3
==========================================
- Hits 3971 3970 -1
- Misses 254 258 +4
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
gaborbernat
requested changes
Sep 14, 2020
Contributor
gaborbernat
left a comment
gaborbernat
left a comment
There was a problem hiding this comment.
I'd expect some type of test here too 🤔
gaborbernat
reviewed
Sep 14, 2020
frostming
changed the title
Signed-off-by: Bernat Gabor <bgabor8@bloomberg.net>
gaborbernat
approved these changes
Sep 18, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thanks for contributing, make sure you address all the checklists (for details on how see
development documentation)!
tox -e fix_lint)docs/changelogfolderThis PR address an issue that read/write on the update log can cause competition on multiple processes.
Close #1938